Juan Hernandez has posted comments on this change. Change subject: core: Update to Quartz 2.1 ......................................................................
Patch Set 1: (2 inline comments) .................................................... File backend/manager/modules/beans/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/FixedDelayJobListener.java Line 58: In this version of Quartz job listeners are global, not assigned to individual jobs. So this listener will be called for all the jobs, doesn't matter if they are fixed delay or not. The way I found to act only on fixed delay jobs is create the FIXED_DELAY_ENABLED property, add it only to fixed delay jobs and check here. See here for details of the job listener changes in Quartz 2.x: http://quartz-scheduler.org/documentation/quartz-2.x/migration-guide Go to the "Changes Related To Listeners". .................................................... File backend/manager/modules/beans/scheduler/src/test/java/org/ovirt/engine/core/utils/timer/SchedulerUtilQuartsImplTest.java Line 81: TimeUnit.MILLISECONDS); No reason, I will remove it. -- To view, visit http://gerrit.ovirt.org/3250 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib86bab5350a01fce9cff02c91c25b35f0d15e7e0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
