Einav Cohen has posted comments on this change. Change subject: packaging: setup: Update Default DC compatibility level as 3.1 in gluster mode ......................................................................
Patch Set 2: Hi Sahina, I apologize for the extremely late response. I am not a big expert on gluster and/or ovirt upgrade paths, however, this is my opinion: IIUC, gluster-only clusters do not really need Data-Centers, and the fact that they are added behind the scenes to the Default DC is somewhat a 'hack'. Ideally, I would want to see proper ovirt support in "orphan" Clusters (i.e. clusters that don't belong to any data-center) for gluster-only clusters. If this will be implemented, one of the things that would need to be done is to ignore any DC-related validation conditions when adding a new "orphan" (gluster-only) Cluster to the system. Therefore, the solution of adjusting the code to ignore DC-related validation conditions when adding a gluster-only Cluster seems more correct to me (I realize that the code change would need to be significantly larger, however if it is taking a step in the right direction - it is worth it in my view). In addition, for gluster-only application-mode, I would want that in the initial DB setup stage, no Default DC will be added at all (again - assuming we have proper "orphan" Clusters support). Therefore, any manipulation to the currently-somewhat-"abused" Default DC indeed seems a bit hacky and incorrect, as Alon and Yair mentioned before. If I was incorrect in any of my assumptions, and / or if you have any further questions or comments - please let me know. Thanks. -- To view, visit http://gerrit.ovirt.org/19185 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I989755cd72b977e7398049008311a540a13dfb3c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Aravinda VK <avish...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Aravinda VK <avish...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
