Daniel Erez has posted comments on this change.
Change subject: webadmin: Create default profile when changing to VM network
......................................................................
Patch Set 3:
(1 comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java
Line 137: new NewVnicProfileModel(getSourceListModel(),
getSelectedDc().getcompatibility_version(), false,
Line 138: getSelectedDc().getId());
Line 139:
Line 140: // make sure default profile's name is in sync with network's
name
Line 141: newModel.getName().setEntity(getName().getEntity());
when do we set Name's entity? (again, just wondering if we can avoid the
duplicate code).
Line 142: getName().getEntityChangedEvent().addListener(new
IEventListener() {
Line 143:
Line 144: @Override
Line 145: public void eventRaised(Event ev, Object sender,
EventArgs args) {
--
To view, visit http://gerrit.ovirt.org/19902
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6764a5d99a9471e6ae07f31ab8552d41b1c28f6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
