Greg Padgett has posted comments on this change. Change subject: lib: fix acceptance of keyword arguments for vdsm api ......................................................................
Patch Set 2: (2 comments) .................................................... File ovirt_hosted_engine_ha/lib/vds_client.py Line 62: retry = 0 Line 63: response = None Line 64: new_args = list(args) Line 65: # Add keyword args to argument list as a dict for vds api compatibility Line 66: if len(kwargs): Done Line 67: new_args.append(kwargs) Line 68: while retry < constants.VDS_CLIENT_MAX_RETRY: Line 69: try: Line 70: response = method(*new_args) Line 63: response = None Line 64: new_args = list(args) Line 65: # Add keyword args to argument list as a dict for vds api compatibility Line 66: if len(kwargs): Line 67: new_args.append(kwargs) It does require a dict--the api we're calling passes the parameters through an xml-rpc server which unfortunately has no notion of keyword arguments. The kwargs are here in the agent api for convenience and to match the vdsClient cli calling conventions. Line 68: while retry < constants.VDS_CLIENT_MAX_RETRY: Line 69: try: Line 70: response = method(*new_args) Line 71: break -- To view, visit http://gerrit.ovirt.org/19872 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9931d6c87b0798152bf344ddd8b9328ce01565a8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
