Eli Mesika has posted comments on this change.

Change subject: restapi: Adding details to step
......................................................................


Patch Set 3: Code-Review+1

(3 comments)

....................................................
File 
backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
Line 3611:       </xs:extension>
Line 3612:     </xs:complexContent>
Line 3613:   </xs:complexType>
Line 3614: 
Line 3615:   <xs:element name="stepdetail" type="StepDetail"/>
should be step_detail IIRC
Line 3616:   <xs:complexType name="StepDetail">
Line 3617:     <xs:annotation>
Line 3618:       <xs:appinfo>
Line 3619:          <jaxb:class name="StepDetail"/>


Line 3629:       </xs:extension>
Line 3630:     </xs:complexContent>
Line 3631:   </xs:complexType>
Line 3632: 
Line 3633:   <xs:element name="volumestepdetail" 
type="GlusterVolumeStepDetail"/>
should be volume_step_detail IIRC
Line 3634:   <xs:complexType name="GlusterVolumeStepDetail">
Line 3635:     <xs:annotation>
Line 3636:       <xs:appinfo>
Line 3637:          <jaxb:class name="GlusterVolumeStepDetail"/>


....................................................
File 
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
Line 4122:     body:
Line 4123:       parameterType: null
Line 4124:       signatures: []
Line 4125:     urlparams: {}
Line 4126:     headers: 
TWS
Line 4127:       All-Content: {value: true|false, required: false}
Line 4128: - name: /api/jobs/{job:id}/steps|rel=add
Line 4129:   description: add a new step to the external job
Line 4130:   request:


-- 
To view, visit http://gerrit.ovirt.org/19685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1f7559d5700823cd4ee0a28a826074d22679d23
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to