Moti Asayag has posted comments on this change.
Change subject: engine: Lazily initialize VM interfaces list
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
Line 169: return interfaces;
Line 170: }
Line 171:
Line 172: protected void removeVmNetwork() {
Line 173: if (getInterfaces() != null) {
perhaps
if (!getInterfaces().isEmpty() ) {}
is more suitable here, cause getInterfaces() should return a list (either empty
or not, but not null).
Line 174: for (VmNic iface : getInterfaces()) {
Line 175:
MacPoolManager.getInstance().freeMac(iface.getMacAddress());
Line 176: }
Line 177: }
--
To view, visit http://gerrit.ovirt.org/19964
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2c08ea82134b398344dfed41e5000de2fe98a74
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
