Mike Kolesnik has uploaded a new change for review.

Change subject: engine: Block hot updating internal to external network
......................................................................

engine: Block hot updating internal to external network

Hot updating was blocked but broken due to bad code change, fixing it.

Change-Id: I13581ac002bd2b0592e7a26f7524ba8824563f20
Bug-Url: https://bugzilla.redhat.com/1016982
Signed-off-by: Mike Kolesnik <mkole...@redhat.com>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/07/20007/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java
index b8a54ab..d898675 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java
@@ -202,7 +202,7 @@
             return false;
         }
 
-        Network network = null;
+        Network network = 
NetworkHelper.getNetworkByVnicProfileId(getInterface().getVnicProfileId());
         if (getRequiredAction() == RequiredAction.UPDATE_VM_DEVICE) {
             Network oldNetwork = 
NetworkHelper.getNetworkByVnicProfileId(oldIface.getVnicProfileId());
             if 
(!validate(nicValidator.hotUpdateDoneWithInternalNetwork(oldNetwork, network))) 
{


-- 
To view, visit http://gerrit.ovirt.org/20007
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I13581ac002bd2b0592e7a26f7524ba8824563f20
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkole...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to