Gilad Chaplik has posted comments on this change. Change subject: engine: support versions for vm propeties ......................................................................
Patch Set 1: (6 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java Line 156: .getVdsGroupDAO() disagree, DbFacade.getInstance().getVdsGroupDAO() is public therefore I can use it. you can change the accessibility of this method and change it all over in a different patch. Line 555: .getcompatibility_version(), same there .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmCustomPropertiesQuery.java Line 12: disagree, you use it as string in getUserDefinedVMProperties, it is private, if you want the Version you can use getVersion() .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java Line 169: handleCustomPropertiesError(validationErrors, getReturnValue().getCanDoActionMessages()); same there Line 280: .get(getParameters().getVm().getvds_group_id()) same there .................................................... File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/QueriesTest.java Line 85: agreed -- To view, visit http://gerrit.ovirt.org/3651 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If132148714e37f48ff3fc5c7bd4bdaa97df248dc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
