Michael Pasternak has posted comments on this change. Change subject: restapi: Adding support for copy/move disk from disk collection. ......................................................................
Patch Set 10: (2 comments) please: 1. add description of the feature in the FeaturesHelper 2. please add rsdl_metadat.yaml desriptors .................................................... Commit Message Line 7: restapi: Adding support for copy/move disk from disk collection. Line 8: Line 9: Adding support for the following urls: Line 10: /api/disks/{disk:id}/copy Line 11: /api/disks/{disk:id}/move it also effects disk under BackendStorageDomainDisk Line 12: Line 13: Change-Id: I516341d3e033a94a997ac5320312e75a5ed1576c Line 14: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=911348 .................................................... File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDiskResource.java Line 66: Line 67: public Response move(Action action) { Line 68: validateParameters(action, "storageDomain.id|name"); Line 69: Guid storageDomainId = getStorageDomainId(action); Line 70: Guid imageId = asGuid(get().getImageId()); the id of the diks from URI is not a ImageId? Line 71: MoveDisksParameters params = Line 72: new MoveDisksParameters(Collections.singletonList(new MoveDiskParameters( Line 73: imageId, Line 74: Guid.Empty, -- To view, visit http://gerrit.ovirt.org/13973 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I516341d3e033a94a997ac5320312e75a5ed1576c Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches