Alexander Wels has posted comments on this change. Change subject: webadmin: remove quota comsumer is broken ......................................................................
Patch Set 1: Code-Review-1 We changed the way the messages get generated that are displayed in the confirm remove dialogs. Before we had the string generated somewhere in a model, which does not allow us to i18n the messages. In http://gerrit.ovirt.org/#/c/18936/ I added a new presenter and view that does know how to properly display the messages. This patch would reverse that for the Quota dialog. Have you tested that you don't get java object addresses as messages now, as the presenter you are putting in would just take the quota object and call toString on it. -- To view, visit http://gerrit.ovirt.org/19959 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I794983826b8b6fc9fffc6f504db11fce00788633 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
