Daniel Erez has posted comments on this change. Change subject: webadmin: Cannot add hypervisor host when use chinese support ......................................................................
Patch Set 5: Code-Review+2 (1 comment) .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/InstallModel.java Line 118: Line 119: setOverrideIpTables(new EntityModel()); Line 120: getOverrideIpTables().setEntity(false); Line 121: setUserName(new EntityModel()); Line 122: getUserName().setEntity(RootUserName); you can reuse the constant in HostModel.. Line 123: // TODO: remove setIsChangable when configured ssh username is enabled Line 124: getUserName().setIsChangable(false); Line 125: setPublicKey(new EntityModel()); Line 126: getPublicKey().setEntity(constants.empty()); -- To view, visit http://gerrit.ovirt.org/19551 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifdc4a332a297bca1b7c99bc6ede5a5aeacbc6431 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
