Daniel Erez has submitted this change and it was merged.
Change subject: core: clearing snapshot_id on disk detach
......................................................................
core: clearing snapshot_id on disk detach
When detaching a DiskImage, the snapshot [1] ID should be cleared.
Otherwise, 'DiskImageDAO -> getAllSnapshotsForVmSnapshot' returns
floating DiskImages (which shouldn't be taken into account in any
flow since they're not relevant with regards to snapshots).
Note: when attaching a DiskImage, the snapshot ID is already updated
properly according to the VM.
[1] only an active snapshot since detaching a disk with snapshots
is blocked at canDo phase.
Change-Id: Iad60d2a6500f4bd738095949c7e36a4ec34122c3
Bug-Url: https://bugzilla.redhat.com/1015170
Signed-off-by: Daniel Erez <de...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachDiskFromVmCommand.java
1 file changed, 7 insertions(+), 0 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19895
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iad60d2a6500f4bd738095949c7e36a4ec34122c3
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
