Nir Soffer has posted comments on this change.
Change subject: engine: Set correct size of iso files and floppies
......................................................................
Patch Set 8:
(1 comment)
Possible cleanup
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java
Line 572: syncObject.unlock();
Line 573: }
Line 574: }
Line 575:
Line 576: private static long retrieveIsoFileSize(Map.Entry<String,
Map<String, Object>> fileStats) {
fileStats is confusing here, since we use it for the map, and here it is one
entry in the fileStats map.
I think it would be more clear and simpler this method would accept one file
stats map instead.
private static long retrieveIsoFileSize(Map<String, Object> stats)
Line 577: try {
Line 578: return Long.valueOf((String)
fileStats.getValue().get(VdsProperties.size));
Line 579: } catch (RuntimeException e) {
Line 580: // Illegal number or null are treated as not available,
--
To view, visit http://gerrit.ovirt.org/19549
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I77bd99beb8138524b25f0afdcce0815ad8664f0f
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
