Sahina Bose has posted comments on this change. Change subject: engine: Infrastrucutre changes for Start Remove Brick ......................................................................
Patch Set 1: (3 comments) Is updateBrick methods part of this patch. I think you should keep this patch limited to introducing remove all in batch .................................................... Commit Message Line 4: Commit: Ramesh Nachimuthu <[email protected]> Line 5: CommitDate: 2013-10-07 13:08:57 +0530 Line 6: Line 7: engine: Infrastrucutre changes for Start Remove Brick Line 8: Please change the commit message to indicate that you are introducing batch removal Line 9: Infrastructure changes to enable Start Remove Brick in gluster. Line 10: Line 11: Change-Id: I95d27f571e32c5a91823511fbf5964ec79282afa .................................................... File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/MassOperationsGenericDaoDbFacade.java Line 63: /** Line 64: * Enables to send remove procedure name as a parameter that overrides the default one. In case this parameter is Line 65: * null, default procedure is used. Line 66: */ Line 67: protected void removeAllInBatch(String procedureName, Collection<T> paramValue, MapSqlParameterMapper<T> mapper) { Can we call paramValue as paramValues as this is a collection? Line 68: getCallsHandler().executeStoredProcAsBatch(procedureName == null ? getProcedureNameForRemove() : procedureName, Line 69: paramValue, Line 70: mapper); Line 71: } .................................................... File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterBrickDao.java Line 34: public GlusterBrickEntity getBrickByServerIdAndDirectory(Guid serverId, String brickDirectory); Line 35: Line 36: public void updateBrickTask(Guid brickId, Guid taskId); Line 37: Line 38: public void updateBrickTasksInBatch(Collection<GlusterBrickEntity> bricks); is the updatebrick change part of this patch? -- To view, visit http://gerrit.ovirt.org/19912 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95d27f571e32c5a91823511fbf5964ec79282afa Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
