Shubhendu Tripathi has posted comments on this change.
Change subject: gluster: Removed check of async task details in volume
......................................................................
Patch Set 2:
(3 comments)
....................................................
Commit Message
Line 5: CommitDate: 2013-10-04 14:25:40 +0530
Line 6:
Line 7: gluster: Removed check of async task details in volume
Line 8:
Line 9: Removed checking the existence of async task details in volume entoty
done
Line 10: for the purpose of hcecking the rebalance execution status on a volume.
Line 11: This is not required and we should always depend upon the actual value
Line 12: returned from glusterfs for the rebalance status as that value would be
Line 13: the uptodate and correct value.
Line 6:
Line 7: gluster: Removed check of async task details in volume
Line 8:
Line 9: Removed checking the existence of async task details in volume entoty
Line 10: for the purpose of hcecking the rebalance execution status on a volume.
done
Line 11: This is not required and we should always depend upon the actual value
Line 12: returned from glusterfs for the rebalance status as that value would be
Line 13: the uptodate and correct value.
Line 14:
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeRebalanceStatusQuery.java
Line 46: new
GlusterVolumeVDSParameters(getUpServerId(clusterId), volume.getName()));
Line 47:
Line 48: // Set the volume re-balance start time
Line 49: GlusterVolumeTaskStatusEntity entity =
(GlusterVolumeTaskStatusEntity) returnValue.getReturnValue();
Line 50: List<Step> stepsList =
getStepDao().getStepsByExternalId(volume.getAsyncTask().getTaskId());
Will check for a NPE
Line 51: if (stepsList != null && !stepsList.isEmpty()) {
Line 52: entity.setStartTime(stepsList.get(0).getStartTime());
Line 53: }
Line 54:
--
To view, visit http://gerrit.ovirt.org/19864
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I54a0f0949cfc8c2fb46bec816519449e583a6b65
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
