Eli Mesika has posted comments on this change. Change subject: core: Introduce CDI for Commands dependencies ......................................................................
Patch Set 11: Code-Review+1 (2 comments) .................................................... Commit Message Line 16: at all since paramater object can't be injected?) Line 17: Line 18: To inject dependecies into Command object I hooked into the Line 19: CommandFactory and used welds Line 20: framework to create an InjectionTarget on the Command type, and then in in=>it Line 21: could be injected - look at InjectionHelper Line 22: Line 23: next, I used prtoducer methods to signal the weld framework where it Line 24: should get the instances from, namely which factory method Line 41: Line 42: * more injected dependencies are also in progress: Line 43: Config - will extract a Config interface from the Line 44: current one Line 45: DAOs - as Yair commented its better the injecting the the=>to Line 46: DbFacade instead Line 47: Line 48: * more managed beans to support Line 49: VDS broker commands -- To view, visit http://gerrit.ovirt.org/5575 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7f604ff91847b698efe84a09f724ba0492a672c1 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Asaf Shakarchi <a...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Liran Zelkha <liran.zel...@gmail.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
