Kanagaraj M has posted comments on this change.

Change subject: webadmin : Clicking on the 'x' button should close the status 
dialog.
......................................................................


Patch Set 1:

(2 comments)

....................................................
Commit Message
Line 3: AuthorDate: 2013-10-07 11:07:08 +0530
Line 4: Commit:     Anmol Babu <anb...@redhat.com>
Line 5: CommitDate: 2013-10-07 11:07:08 +0530
Line 6: 
Line 7: webadmin : Clicking on the 'x' button should close the status dialog.
commit header should be more specific, some thing like

'fixed rebalance  status dialog close button issue'
Line 8: 
Line 9: Fixed Clicking on the 'x' button does not close the status dialog.
Line 10: 
Line 11: Now,Clicking on the 'x' button closes the status dialog.


....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java
Line 474:             onRemoveVolume();
Line 475:         }
Line 476:     }
Line 477: 
Line 478:     private void closeConfirmationWindow() {
add a null check for getConfirmWindow()
Line 479:         getConfirmWindow().stopProgress();
Line 480:         setConfirmWindow(null);
Line 481:     }
Line 482: 


-- 
To view, visit http://gerrit.ovirt.org/19910
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0363784b13b26603f1f6279423adcac5e592045
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to