Daniel Erez has posted comments on this change. Change subject: engine: Fix NPE in UpdateVmDiskCommand ......................................................................
Patch Set 1: (1 comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java Line 476: !StringUtils.equals(getOldDisk().getDiskAlias(), getNewDisk().getDiskAlias()); Line 477: } Line 478: Line 479: private boolean shouldUpdateImageProperties() { Line 480: if (getOldDisk().getDiskStorageType() == DiskStorageType.IMAGE) { shouldn't we return if *not* DiskStorageType.IMAGE Line 481: return false; Line 482: } Line 483: Guid oldQuotaId = ((DiskImage) getOldDisk()).getQuotaId(); Line 484: return !ObjectUtils.objectsEqual(oldQuotaId, getQuotaId()); -- To view, visit http://gerrit.ovirt.org/19898 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If689b77cfe4b4a466b70cd9194e99f0eeafcca09 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches