Sergey Gotliv has uploaded a new change for review.
Change subject: engine: Align javadocs with methods' signatures
......................................................................
engine: Align javadocs with methods' signatures
Change-Id: Ib8007f3e800c99cf5cc18a96bce9b8ed372cbf6a
Signed-off-by: Sergey Gotliv <sgot...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java
M
backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/SchedulerUtil.java
2 files changed, 14 insertions(+), 18 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/97/19897/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java
index f516a0e..52a33dd 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java
@@ -400,7 +400,7 @@
/**
* Reset the list of problematic repository files, before starting the
refresh procedure.
* uses for multy thread caching.
- * @see #addRepoFileToProblematicList()
+ * @see #addRepoFileToProblematicList(List<RepoImage>)
*/
private synchronized void resetProblematicList() {
problematicRepoFileList.clear();
@@ -583,12 +583,10 @@
* Try to update the cached table from the VDSM, if succeeded fetch the
file list again from the DB. if not ,handle
* the log message.
*
- * @param IsoStorageDomainId
- * - The storage domain Id we want to get the file list from.
- * @param fileListMD
- * - File list of repository files.
- * @param repoFileMetaData
- * - repository file we fetch the domain counting on its domain
id.
+ * @param storagePoolId
+ * - The storage pool id we want to get the file list from.
+ * @param storageDomainId
+ * - The storage domain id we want to get the file list from.
*/
private synchronized void refreshActivatedStorageDomainFromVdsm(Guid
storagePoolId, Guid storageDomainId) {
if (!updateIsoListFromVDSM(storagePoolId, storageDomainId)) {
diff --git
a/backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/SchedulerUtil.java
b/backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/SchedulerUtil.java
index d55d0ad..b56abf6 100644
---
a/backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/SchedulerUtil.java
+++
b/backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/SchedulerUtil.java
@@ -11,7 +11,7 @@
public interface SchedulerUtil {
/**
- * schedules a fixed-delay job to run the method with the given name on the
+ * Schedules a fixed-delay job to run the method with the given name on the
* given instance.
*
* @param instance
@@ -39,7 +39,7 @@
TimeUnit timeUnit);
/**
- * schedules a one time job.
+ * Schedules a one time job.
*
* @param instance
* - the instance to activate the method on timeout
@@ -63,7 +63,7 @@
TimeUnit timeUnit);
/**
- * reschedule the job associated with the given old trigger with the new
+ * Reschedule the job associated with the given old trigger with the new
* trigger.
*
* @param oldTriggerName
@@ -76,7 +76,7 @@
void rescheduleAJob(String oldTriggerName, String oldTriggerGroup, Trigger
newTrigger);
/**
- * pauses the job with the given jobId
+ * Pauses the job with the given jobId.
*
* @param jobId
* - the id of the job to be paused
@@ -92,7 +92,7 @@
public void deleteJob(String jobId);
/**
- * resumes the job with the given jobId
+ * Resumes the job with the given jobId.
*
* @param jobId
* - the id of the job to be resumed
@@ -100,7 +100,7 @@
public void resumeJob(String jobId);
/**
- * Execute immediately the job with the given jobId
+ * Execute immediately the job with the given jobId.
*
* @param jobId
* - the id of the job to be triggered
@@ -114,7 +114,7 @@
public void shutDown();
/**
- * Starts the scheduler
+ * Starts the scheduler.
*/
public void create();
@@ -124,7 +124,7 @@
Scheduler getRawScheduler();
/**
- * schedules a cron job.
+ * Schedules a cron job.
*
* @param instance
* - the instance to activate the method on timeout
@@ -145,7 +145,7 @@
String cronExpression);
/**
- * schedules a job with a configurable delay.
+ * Schedules a job with a configurable delay.
*
* @param instance
* - the instance to activate the method on timeout
@@ -157,8 +157,6 @@
* - the method input parameters
* @param initialDelay
* - the initial delay before the first activation
- * @param taskDelay
- * - the name of the config value that sets the delay between
jobs
* @param timeUnit
* - the unit of time used for initialDelay and taskDelay.
* @return the scheduled job id
--
To view, visit http://gerrit.ovirt.org/19897
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib8007f3e800c99cf5cc18a96bce9b8ed372cbf6a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
