Yair Zaslavsky has posted comments on this change.
Change subject: core: Add DbGroup
......................................................................
Patch Set 3:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AdGroupsHandlingCommandBase.java
Line 11: import org.ovirt.engine.core.common.businessentities.tags;
Line 12: import org.ovirt.engine.core.compat.Guid;
Line 13: import org.ovirt.engine.core.dal.dbbroker.DbFacade;
Line 14:
Line 15: public abstract class AdGroupsHandlingCommandBase<T extends
AdElementParametersBase> extends CommandBase<T> {
Hi,
In what patch are you going to change the AdGroups prefix of trhe class name ?
Same question to the parameters class.
Line 16: protected tags _tag;
Line 17: private LdapGroup mGroup;
Line 18: private String mGroupName;
Line 19:
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllAdGroupsQuery.java
Line 9: }
Line 10:
Line 11: @Override
Line 12: protected void executeQueryCommand() {
Line 13:
getQueryReturnValue().setReturnValue(DbFacade.getInstance().getDbGroupDao().getAll());
Shouldn't you transform the result to a list of LdapGroup ?
Line 14: }
--
To view, visit http://gerrit.ovirt.org/17544
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idb1a7146c29eb74f97e10043d65b5a67f1430021
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
