Greg Padgett has uploaded a new change for review.
Change subject: agent: fix arguments to vdsClient migrate invocation
......................................................................
agent: fix arguments to vdsClient migrate invocation
The run_vds_client_command() function expects a boolean parameter for
ssl state but was being sent a text string, causing migration to fail.
Change-Id: I25aaaa3d6cc32a8e36e6366a24cf2db43c0039b0
Signed-off-by: Greg Padgett <gpadg...@redhat.com>
---
M ovirt_hosted_engine_ha/agent/hosted_engine.py
1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-hosted-engine-ha
refs/changes/73/19873/1
diff --git a/ovirt_hosted_engine_ha/agent/hosted_engine.py
b/ovirt_hosted_engine_ha/agent/hosted_engine.py
index 89304ba..756084b 100644
--- a/ovirt_hosted_engine_ha/agent/hosted_engine.py
+++ b/ovirt_hosted_engine_ha/agent/hosted_engine.py
@@ -32,6 +32,7 @@
from ..lib import exceptions as ex
from ..lib import log_filter
from ..lib import metadata
+from ..lib import util
from ..lib import vds_client as vdsc
@@ -883,12 +884,14 @@
MIGRATE state. Move the VM to the destination host.
"""
vm_id = self._config.get(config.VM, config.VM_UUID)
+ use_ssl = util.to_bool(self._config.get(config.ENGINE,
+ config.VDSM_SSL))
best_host_id = self._rinfo['migration-host-id']
if self._rinfo['migration-status'] == self.MigrationStatus.PENDING:
try:
vdsc.run_vds_client_cmd(
'0',
- self._config.get(config.ENGINE, config.VDSM_SSL),
+ use_ssl,
'migrate',
vmId=vm_id,
method='online',
@@ -908,7 +911,7 @@
else:
res = vdsc.run_vds_client_cmd(
'0',
- self._config.get(config.ENGINE, config.VDSM_SSL),
+ use_ssl,
'migrate',
vmId=vm_id
)
--
To view, visit http://gerrit.ovirt.org/19873
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I25aaaa3d6cc32a8e36e6366a24cf2db43c0039b0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadg...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
