Sergey Gotliv has posted comments on this change. Change subject: [WIP]engine: Remove calls to getImageDomainsList API ......................................................................
Patch Set 3: (2 comments) 1. I abandoned all not related changes I tried to do in my previous patch sets. 2. I still have to create new error message. .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java Line 780: ACTION_TYPE_FAILED_CANNOT_REMOVE_ACTIVE_DEVICE(ErrorType.CONFLICT), Line 781: ACTION_TYPE_FAILED_IMPORT_CLONE_NOT_COLLAPSED(ErrorType.BAD_PARAMETERS), Line 782: Line 783: /* VDSM Error that propagates up to the client. See VdcBLLErrors */ Line 784: ERROR_GET_STORAGE_DOMAIN_LIST(ErrorType.INTERNAL_ERROR), // VdcBllErrors.GetStorageDomainListError Have to check whether this error code and related error messages can be removed or not. Line 785: Line 786: ERROR_GET_IMAGE_LIST(ErrorType.INTERNAL_ERROR), Line 787: Line 788: USER_CANNOT_FORCE_RECONNECT_TO_VM(ErrorType.CONFLICT), Line 783: /* VDSM Error that propagates up to the client. See VdcBLLErrors */ Line 784: ERROR_GET_STORAGE_DOMAIN_LIST(ErrorType.INTERNAL_ERROR), // VdcBllErrors.GetStorageDomainListError Line 785: Line 786: ERROR_GET_IMAGE_LIST(ErrorType.INTERNAL_ERROR), Line 787: I still have to create appropriate error message for this error code. Line 788: USER_CANNOT_FORCE_RECONNECT_TO_VM(ErrorType.CONFLICT), Line 789: // Engine maintenance mode Line 790: ENGINE_IS_RUNNING_IN_MAINTENANCE_MODE(ErrorType.CONFLICT), Line 791: // Engine prepare mode -- To view, visit http://gerrit.ovirt.org/15951 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33069871db34e8b129c4d80098523654cd2a0629 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Eduardo <ewars...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: liron aravot <liron.ara...@gmail.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
