Gilad Chaplik has posted comments on this change.
Change subject: core, webadmin: Show only supported watchdogs
......................................................................
Patch Set 4:
(4 comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
Line 1256
Line 1257
Line 1258
Line 1259
Line 1260
(*)
Line 1137: VdcQueryType.GetStorageDomainById,
VdcQueryType.GetDataCentersWithPermittedActionOnClusters,
Line 1138: VdcQueryType.GetClustersWithPermittedAction,
VdcQueryType.GetVmTemplatesWithPermittedAction,
Line 1139: VdcQueryType.GetVdsGroupById,
VdcQueryType.GetStoragePoolById, VdcQueryType.GetAllDisksByVmId,
Line 1140: VdcQueryType.GetVmTemplate,
VdcQueryType.GetVmConfigurationBySnapshot, VdcQueryType.GetAllVdsGroups,
Line 1141:
VdcQueryType.GetPermittedStorageDomainsByStoragePoolId,
VdcQueryType.GetHostsByClusterId,
please add the the query type enum here as well.
Line 1142: VdcQueryType.Search });
Line 1143:
Line 1144: this.behavior = behavior;
Line 1145: this.behavior.setModel(this);
Line 1771: private void updateWatchdogItems(ArrayList<String>
watchDogModels) {
Line 1772: String oldWatchdogSelected = (String)
getWatchdogModel().getSelectedItem();
Line 1773:
Line 1774: watchDogModels.add(0, null);
Line 1775: getWatchdogModel().setItems(watchDogModels);
missing (*) (translating the enum).
Line 1776:
Line 1777: if (watchDogModels.contains(oldWatchdogSelected)) {
Line 1778: getWatchdogModel().setSelectedItem(oldWatchdogSelected);
Line 1779: }
....................................................
File packaging/conf/osinfo-defaults.properties
Line 34: # OS family values: Linux/Windows/other
Line 35: os.other.family.value = other
Line 36:
Line 37: # CPU architecture (*not* the bus width 64/32 bit). Currently only x86
is supported
Line 38: # but ppc7 is a work in progress and possibly arm someday as well
why did you remove the example?
Line 39: os.other.cpuArchitecture.value = x86
Line 40:
Line 41: os.other.bus.value = 32
Line 42: os.other.resources.minimum.ram.value = 256
--
To view, visit http://gerrit.ovirt.org/18221
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib23f7357751025ff71c0deceda02aa51c2d8542c
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gustavo Frederico Temple Pedrosa <gustavo.pedr...@eldorado.org.br>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
<gustavo.pedr...@eldorado.org.br>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianc...@eldorado.org.br>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Vitor de Lima <vitor.l...@eldorado.org.br>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
