Maor Lipchuk has uploaded a new change for review. Change subject: core: Removing proxy method ......................................................................
core: Removing proxy method executeReadAndReturnMap only acts as a proxy method to executeReadList, therefor it can be removed. Change-Id: I3079a893feaa49ef2b992c83fad97953fee21313 Signed-off-by: Maor Lipchuk <mlipc...@redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/SimpleJdbcCallsHandler.java 1 file changed, 1 insertion(+), 9 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/30/19830/1 diff --git a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/SimpleJdbcCallsHandler.java b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/SimpleJdbcCallsHandler.java index a219a43..bf8d17c 100644 --- a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/SimpleJdbcCallsHandler.java +++ b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/SimpleJdbcCallsHandler.java @@ -99,16 +99,8 @@ public <T> List<T> executeReadList(final String procedureName, final RowMapper<T> mapper, final MapSqlParameterSource parameterSource) { - Map<String, Object> resultsMap = executeReadAndReturnMap(procedureName, mapper, parameterSource); + Map<String, Object> resultsMap = executeImpl(procedureName, parameterSource, createCallForRead(procedureName, mapper, parameterSource)); return (List<T>) (resultsMap.get(BaseDAODbFacade.RETURN_VALUE_PARAMETER)); - } - - public <T> Map<String, Object> executeReadAndReturnMap(final String procedureName, - final RowMapper<T> mapper, - final MapSqlParameterSource parameterSource) { - Map<String, Object> resultsMap = - executeImpl(procedureName, parameterSource, createCallForRead(procedureName, mapper, parameterSource)); - return resultsMap; } private CallCreator createCallForRead(final String procedureName, -- To view, visit http://gerrit.ovirt.org/19830 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3079a893feaa49ef2b992c83fad97953fee21313 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches