Noam Slomianko has posted comments on this change.

Change subject: core: disable when external scheduler is down
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

Needs a separate method for "marking all as disabled", because the one that 
receive parameters is needed.

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerDiscoveryThread.java
Line 55:         }
Line 56: 
Line 57:         allPolicyUnits.removeAll(foundInBoth);
Line 58:         // found in the db but not found in discovery, mark as such
Line 59:         markExternalPoliciesAsDisabled();
This will now disable all policy units and not only the ones not found
Line 60: 
Line 61:         SchedulingManager.getInstance().reloadPolicyUnits();
Line 62:     }
Line 63: 


-- 
To view, visit http://gerrit.ovirt.org/18360
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2cd7aa42f85f261f9e55e057b52d7dc4c5738252
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Noam Slomianko <nslom...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Noam Slomianko <nslom...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to