[Engine-patches] Change in ovirt-engine[master]: core: remove redundant use of Integer object.

[mlipchuk]

Maor Lipchuk has uploaded a new change for review.

Change subject: core: remove redundant use of Integer object.
......................................................................

core: remove redundant use of Integer object.

Removing the use of Integer in executeModificationReturnResult.
There is no need to check null value also.

Change-Id: I6b39a95caeddd6d200531e27daf5001cf8251923
Signed-off-by: Maor Lipchuk <mlipc...@redhat.com>
---
M 
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/SimpleJdbcCallsHandler.java
1 file changed, 2 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/19/19819/1

diff --git 
a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/SimpleJdbcCallsHandler.java
 
b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/SimpleJdbcCallsHandler.java
index 85b0900..a219a43 100644
--- 
a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/SimpleJdbcCallsHandler.java
+++ 
b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/SimpleJdbcCallsHandler.java
@@ -75,18 +75,17 @@
     }
 
     public int executeModificationReturnResult(final String procedureName, 
final MapSqlParameterSource paramSource) {
-        Integer procedureResult = null;
         Map<String, Object> result = executeImpl(procedureName, paramSource, 
createCallForModification(procedureName));
         if (!result.isEmpty()) {
             List<?> resultArray = (List<?>) result.values().iterator().next();
             if (resultArray != null && !resultArray.isEmpty()) {
                 Map<?, ?> resultMap = (Map<?, ?>) resultArray.get(0);
                 if (!resultMap.isEmpty()) {
-                    procedureResult = (Integer) 
resultMap.values().iterator().next();
+                    return (Integer)resultMap.values().iterator().next();
                 }
             }
         }
-        return (procedureResult != null) ? procedureResult : 0;
+        return 0;
     }
 
     public <T> T executeRead(final String procedureName,


-- 
To view, visit http://gerrit.ovirt.org/19819
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6b39a95caeddd6d200531e27daf5001cf8251923
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches