Eli Mesika has posted comments on this change.

Change subject: engine: Introduced InternalJob and InternalStep command
......................................................................


Patch Set 3:

(1 comment)

....................................................
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
Line 799:     ACTION_TYPE_NO_STEP(ErrorType.BAD_PARAMETERS),
Line 800:     ACTION_TYPE_NON_MONITORED(ErrorType.NOT_SUPPORTED),
Line 801: 
Line 802:     //Internal Job
Line 803:     ACTION_TYPE_EMPTY_ACTIONTYPE(ErrorType.BAD_PARAMETERS),
Should be (in all other occurrences as well) :

ACTION_TYPE_EMPTY_ACTION_TYPE(
Line 804: 
Line 805:     //watchdog
Line 806:     WATCHDOG_NOT_FOUND(ErrorType.BAD_PARAMETERS),
Line 807:     WATCHDOG_ALREADY_EXISTS(ErrorType.CONFLICT),


-- 
To view, visit http://gerrit.ovirt.org/19182
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I17074d4317c037fa9fcc680f4b0a7a9b3a6b087a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Eli Mesika <elimes...@gmail.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to