Lior Vernia has uploaded a new change for review. Change subject: webadmin: Enabled column resizing in Manage Cluster Networks ......................................................................
webadmin: Enabled column resizing in Manage Cluster Networks In certain locales columns would get wider, to the point where a horizontal scroll bar appeared. This fixes it. Also adjusted some preset widths to look better in English. Change-Id: If7bac93b4de9400996a07ffc98fed3a6343fef34 Bug-Url: https://bugzilla.redhat.com/1009745 Signed-off-by: Lior Vernia <lver...@redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterManageNetworkPopupView.java 1 file changed, 6 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/68/19768/1 diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterManageNetworkPopupView.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterManageNetworkPopupView.java index 723af2a..68c3c72 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterManageNetworkPopupView.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterManageNetworkPopupView.java @@ -58,6 +58,8 @@ } void initEntityModelCellTable(final ApplicationConstants constants, final ApplicationTemplates templates) { + networks.enableColumnResizing(); + CheckboxHeader assignAllHeader = new CheckboxHeader(templates.textForCheckBoxHeader(constants.assignAll())) { @Override protected void selectionChanged(Boolean value) { @@ -95,12 +97,12 @@ } }; - networks.addEntityModelColumn(new TextColumnWithTooltip<EntityModel>() { + networks.addColumn(new TextColumnWithTooltip<EntityModel>() { @Override public String getValue(EntityModel model) { return ((ClusterNetworkModel) model).getDisplayedName(); } - }, constants.nameNetwork()); + }, constants.nameNetwork(), "85px"); //$NON-NLS-1$ networks.addColumn(new CheckboxColumn<EntityModel>(new FieldUpdater<EntityModel, Boolean>() { @Override @@ -201,7 +203,7 @@ return false; } - }, constants.vmNetwork(), "90px"); //$NON-NLS-1$ + }, constants.vmNetwork(), "80px"); //$NON-NLS-1$ networks.addColumn(new CheckboxColumn<EntityModel>(new FieldUpdater<EntityModel, Boolean>() { @Override @@ -246,7 +248,7 @@ clusterNetworkModel.getCluster().getcompatibility_version().toString()); return migrationNetworkEnabled && clusterNetworkModel.isAttached() && !clusterNetworkModel.isExternal(); } - }, constants.migrationNetwork(), "100px"); //$NON-NLS-1$ + }, constants.migrationNetwork(), "105px"); //$NON-NLS-1$ } @Override -- To view, visit http://gerrit.ovirt.org/19768 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If7bac93b4de9400996a07ffc98fed3a6343fef34 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Lior Vernia <lver...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
