Lior Vernia has posted comments on this change.
Change subject: webadmin: Allowed non-draggable NetworkItemPanel
......................................................................
Patch Set 2: Verified+1
(1 comment)
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkItemPanel.java
Line 138:
Line 139: }, ContextMenuEvent.getType());
Line 140:
Line 141: // drag start
Line 142: addBitlessDomHandler(new DragStartHandler() {
Fixed as suggested in following patchset.
I'll tell you what I found out about
getElement().setDraggable(DRAGGABLE_FALSE), is that it actually adds the
draggable property to the element and sets it to true, which is indeed strange.
I don't see that in the GWT implementation of the native JS function, so maybe
it's some kind of browser quirk that Firefox sets draggable to true whenever
that property is initially added.
Line 143: @Override
Line 144: public void onDragStart(DragStartEvent event) {
Line 145: if (!draggable) {
Line 146: return;
--
To view, visit http://gerrit.ovirt.org/19694
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f130803ce2403cc26297ec8d06ef62d23837b96
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
