Eli Mesika has posted comments on this change.

Change subject: core: Cleanup of Vnic and Disk hotplug
......................................................................


Patch Set 1:

(2 comments)

....................................................
File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
Line 155: select fn_db_add_config_value('HardwareInfoEnabled','true','3.2');
Line 156: select fn_db_add_config_value('HardwareInfoEnabled','true','3.3');
Line 157: select 
fn_db_add_config_value('HighUtilizationForEvenlyDistribute','75','general');
Line 158: select 
fn_db_add_config_value('HighUtilizationForPowerSave','75','general');
Line 159: select fn_db_add_config_value('HostTimeDriftInSec','300','general');
You should add handling in the delete section as well in order to cleanup 
current installations
Line 160: select 
fn_db_add_config_value('MigrationSupportForNativeUsb','false','3.0');
Line 161: select 
fn_db_add_config_value('MigrationSupportForNativeUsb','false','3.1');
Line 162: select 
fn_db_add_config_value('MigrationSupportForNativeUsb','true','3.2');
Line 163: select 
fn_db_add_config_value('MigrationSupportForNativeUsb','true','3.3');


Line 164: select 
fn_db_add_config_value('NetworkLinkingSupported','false','3.0');
Line 165: select 
fn_db_add_config_value('NetworkLinkingSupported','false','3.1');
Line 166: select fn_db_add_config_value('NetworkLinkingSupported','true','3.2');
Line 167: select fn_db_add_config_value('NetworkLinkingSupported','true','3.3');
Line 168: select 
fn_db_add_config_value('DisconnectPoolOnReconstruct','0,2','general');
You should add handling in the delete section as well in order to cleanup 
current installations
Line 169: select 
fn_db_add_config_value('InitStorageSparseSizeInGB','1','general');
Line 170: select fn_db_add_config_value('TunnelMigrationEnabled','false','3.0');
Line 171: select fn_db_add_config_value('TunnelMigrationEnabled','false','3.1');
Line 172: select fn_db_add_config_value('TunnelMigrationEnabled','false','3.2');


-- 
To view, visit http://gerrit.ovirt.org/19758
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c38a8ecbbc56fc8ef70c6e45732225ce96ba1f0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gustavo Frederico Temple Pedrosa <gustavo.pedr...@eldorado.org.br>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa 
<gustavo.pedr...@eldorado.org.br>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianc...@eldorado.org.br>
Gerrit-Reviewer: Liran Zelkha <liran.zel...@gmail.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Vitor de Lima <vitor.l...@eldorado.org.br>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to