Juan Hernandez has posted comments on this change. Change subject: engine: Datasource configuration fixes ......................................................................
Patch Set 1: (1 comment) .................................................... File packaging/services/ovirt-engine/ovirt-engine.xml.in Line 150: <share-prepared-statements/> Line 151: </statement> Line 152: <validation> Line 153: <check-valid-connection-sql>select 1</check-valid-connection-sql> Line 154: <background-validation>true</background-validation> This means that connections won't be validated prior to use, so it will impact recovery of the engine when there are short database down times. Are you sure you want to do this? If you finally decide to use it I would suggest to explicitly include the "background-validation-millis" parameter. Line 155: </validation> Line 156: </datasource> Line 157: Line 158: <drivers> -- To view, visit http://gerrit.ovirt.org/19735 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7cbe97f0baf85f8b6785726380a7a4dcb9d20f8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <liran.zel...@gmail.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eli Mesika <elimes...@gmail.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Liran Zelkha <liran.zel...@gmail.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
