Leonardo Bianconi has posted comments on this change. Change subject: core, engine, webadmin: Initial support for alternative architectures ......................................................................
Patch Set 5: (1 comment) .................................................... File packaging/dbscripts/upgrade/03_03_0900_add_architecture_name_column.sql Line 4: -- Existent clusters with cpu_name are x86_64, since alternative architectures are introduced after this upgrade Line 5: UPDATE vds_groups SET architecture = 1 where cpu_name is not NULL and architecture = 0; Line 6: Line 7: -- Update clusters Line 8: create or replace FUNCTION __temp_update_vds_group() This was one of the solutions we had thought (http://comments.gmane.org/gmane.comp.emulators.ovirt.engine.devel/5047), but weird behavior would be introduced, like the one you described (User cannot add a kind of host). I've checked the validations for CPU changing, and the user would face issues to change the CPU name only if there are hosts attached to it, otherwise it can be changed. In this case, the cluster has no hosts attached. I dont know if I'm missing something, if so, please let me know, can you see any issue? Line 9: returns void Line 10: AS $procedure$ Line 11: declare Line 12: r vds_groups%rowtype; -- To view, visit http://gerrit.ovirt.org/18938 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ecd642e2bc05067d55884c948bdaeb6e7838c26 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vitor.l...@eldorado.org.br> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedr...@eldorado.org.br> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianc...@eldorado.org.br> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
