Noam Slomianko has posted comments on this change.

Change subject: webadmin: Add vm name to quota message
......................................................................


Patch Set 1: Code-Review+1

Looking at VdcActionType, only vm related operations require 
QuotaDependency.VDS_GROUP/QuotaDependency.BOTH so it should be safe.

-- 
To view, visit http://gerrit.ovirt.org/19469
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5a55b549f0127fde8b0afd6daae2ac06e0218e3d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Noam Slomianko <nslom...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Noam Slomianko <nslom...@redhat.com>
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

From bf-blender-cvs-boun...@blender.org Tue Oct 01 05:36:22 2013
Return-path: <bf-blender-cvs-boun...@blender.org>
Envelope-to: arch...@mail-archive.com
Delivery-date: Tue, 01 Oct 2013 05:36:22 -0700
Received: from bolt10b.serverbox.net ([208.53.48.136] 
helo=bolt10b.mxthunder.net)
        by mail-archive.com with esmtp (Exim 4.76)
        (envelope-from <bf-blender-cvs-boun...@blender.org>)
        id 1VQzBe-00031R-Da
        for arch...@mail-archive.com; Tue, 01 Oct 2013 05:36:22 -0700
Received: by bolt10b.mxthunder.net (Postfix, from userid 12345)
        id 3cq0Mh0dm2z4slxJ; Tue,  1 Oct 2013 05:35:56 -0700 (PDT)
Received: from proog.blender.org (proog.blender.org [82.94.213.219])
        (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
        (No client certificate requested)
        by bolt10b.mxthunder.net (Postfix) with ESMTPS id 3cq0MH0x7bz4sDTX
        for <arch...@mail-archive.com>; Tue,  1 Oct 2013 05:35:55 -0700 (PDT)
Received: from proog.blender.org (localhost [127.0.0.1])
        by proog.blender.org (Postfix) with ESMTP id 5EE873984F;
        Tue,  1 Oct 2013 14:35:46 +0200 (CEST)
X-Original-To: bf-blender-...@blender.org
Delivered-To: bf-blender-...@blender.org
Received: from projects.blender.org (projects.blender.org [82.94.213.215])
        by proog.blender.org (Postfix) with ESMTP id 37F0839829
        for <bf-blender-...@blender.org>; Tue,  1 Oct 2013 14:35:44 +0200 (CEST)
Received: by projects.blender.org (Postfix, from userid 80)
        id 199411F6687B; Tue,  1 Oct 2013 12:35:44 +0000 (UTC)
MIME-Version: 1.0
X-Mailer: SVN::Notify 2.81: http://search.cpan.org/dist/SVN-Notify/
From: Campbell Barton <ideasma...@gmail.com>
To: bf-blender-...@blender.org
Message-Id: <20131001123544.199411f66...@projects.blender.org>
Date: Tue,  1 Oct 2013 12:35:43 +0000 (UTC)
Subject: [Bf-blender-cvs] SVN commit: /data/svn/bf-blender [60481]
 trunk/blender/source/blender/ editors: check SELECT flags for curves ( was
 checking for nonzero which would break if new files use this field for
 other flags )
X-BeenThere: bf-blender-...@blender.org
X-Mailman-Version: 2.1.9
Precedence: list
Reply-To: bf-committ...@blender.org
List-Id: All commit messages on Blender's source code repository
        <bf-blender-cvs.blender.org>
List-Unsubscribe: <http://lists.blender.org/mailman/listinfo/bf-blender-cvs>, 
        <mailto:bf-blender-cvs-requ...@blender.org?subject=unsubscribe>
List-Archive: <http://lists.blender.org/pipermail/bf-blender-cvs>
List-Post: <mailto:bf-blender-...@blender.org>
List-Help: <mailto:bf-blender-cvs-requ...@blender.org?subject=help>
List-Subscribe: <http://lists.blender.org/mailman/listinfo/bf-blender-cvs>,
        <mailto:bf-blender-cvs-requ...@blender.org?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: bf-blender-cvs-boun...@blender.org
Errors-To: bf-blender-cvs-boun...@blender.org
X-MXTHUNDER-Identifier:  <20131001123544.199411f66...@projects.blender.org>
X-MXTHUNDER-IP-Rating:  0, 82.94.213.219, Ugly c=0.423627 p=-0.639344 Source 
Normal
X-MXTHUNDER-Scan-Result:  0
X-MXTHUNDER-Rules: 
        0-0-0-7843-c
X-MXTHUNDER-Clean:  Yes
X-MXTHUNDER-Group:  OK

Revision: 60481
          
http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=60481
Author:   campbellbarton
Date:     2013-10-01 12:35:43 +0000 (Tue, 01 Oct 2013)
Log Message:
-----------
check SELECT flags for curves (was checking for nonzero which would break if 
new files use this field for other flags)

Modified Paths:
--------------
    trunk/blender/source/blender/editors/space_info/info_stats.c
    trunk/blender/source/blender/editors/transform/transform_manipulator.c
    trunk/blender/source/blender/editors/transform/transform_snap.c

Modified: trunk/blender/source/blender/editors/space_info/info_stats.c
===================================================================
--- trunk/blender/source/blender/editors/space_info/info_stats.c        
2013-10-01 12:11:10 UTC (rev 60480)
+++ trunk/blender/source/blender/editors/space_info/info_stats.c        
2013-10-01 12:35:43 UTC (rev 60481)
@@ -194,9 +194,9 @@
                                a = nu->pntsu;
                                while (a--) {
                                        stats->totvert += 3;
-                                       if (bezt->f1) stats->totvertsel++;
-                                       if (bezt->f2) stats->totvertsel++;
-                                       if (bezt->f3) stats->totvertsel++;
+                                       if (bezt->f1 & SELECT) 
stats->totvertsel++;
+                                       if (bezt->f2 & SELECT) 
stats->totvertsel++;
+                                       if (bezt->f3 & SELECT) 
stats->totvertsel++;
                                        bezt++;
                                }
                        }

Modified: trunk/blender/source/blender/editors/transform/transform_manipulator.c
===================================================================
--- trunk/blender/source/blender/editors/transform/transform_manipulator.c      
2013-10-01 12:11:10 UTC (rev 60480)
+++ trunk/blender/source/blender/editors/transform/transform_manipulator.c      
2013-10-01 12:35:43 UTC (rev 60481)
@@ -428,11 +428,11 @@
                                                                totsel++;
                                                        }
                                                        else {
-                                                               if (bezt->f1) {
+                                                               if (bezt->f1 & 
SELECT) {
                                                                        
calc_tw_center(scene, bezt->vec[(v3d->around == V3D_LOCAL) ? 1 : 0]);
                                                                        
totsel++;
                                                                }
-                                                               if (bezt->f3) {
+                                                               if (bezt->f3 & 
SELECT) {
                                                                        
calc_tw_center(scene, bezt->vec[(v3d->around == V3D_LOCAL) ? 1 : 2]);
                                                                        
totsel++;
                                                                }

Modified: trunk/blender/source/blender/editors/transform/transform_snap.c
===================================================================
--- trunk/blender/source/blender/editors/transform/transform_snap.c     
2013-10-01 12:11:10 UTC (rev 60480)
+++ trunk/blender/source/blender/editors/transform/transform_snap.c     
2013-10-01 12:35:43 UTC (rev 60481)
@@ -134,7 +134,8 @@
 
 bool activeSnap(TransInfo *t)
 {
-       return (t->modifiers & (MOD_SNAP | MOD_SNAP_INVERT)) == MOD_SNAP || 
(t->modifiers & (MOD_SNAP | MOD_SNAP_INVERT)) == MOD_SNAP_INVERT;
+       return ((t->modifiers & (MOD_SNAP | MOD_SNAP_INVERT)) == MOD_SNAP) ||
+              ((t->modifiers & (MOD_SNAP | MOD_SNAP_INVERT)) == 
MOD_SNAP_INVERT);
 }
 
 void drawSnapping(const struct bContext *C, TransInfo *t)

_______________________________________________
Bf-blender-cvs mailing list
bf-blender-...@blender.org
http://lists.blender.org/mailman/listinfo/bf-blender-cvs

Reply via email to