Lior Vernia has uploaded a new change for review.

Change subject: webadmin: Defer item selection 'til after items are set
......................................................................

webadmin: Defer item selection 'til after items are set

So far the selection was performed before the list of items was
refreshed in the view, and (presumably because of GWT implementation)
this caused the list of items to not be refreshed immediately.

Change-Id: I9ab512bc315a5f01e9ddb3fe7321b596b83e7cf3
Bug-Url: https://bugzilla.redhat.com/999882
Signed-off-by: Lior Vernia <lver...@redhat.com>
---
M 
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmInterfaceListModelTable.java
1 file changed, 11 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/36/19736/1

diff --git 
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmInterfaceListModelTable.java
 
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmInterfaceListModelTable.java
index bcb2ac0..eb29e57 100644
--- 
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmInterfaceListModelTable.java
+++ 
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmInterfaceListModelTable.java
@@ -22,6 +22,8 @@
 import org.ovirt.engine.ui.uicompat.IEventListener;
 
 import com.google.gwt.core.client.GWT;
+import com.google.gwt.core.client.Scheduler;
+import com.google.gwt.core.client.Scheduler.ScheduledCommand;
 import com.google.gwt.event.shared.EventBus;
 import com.google.gwt.uibinder.client.UiBinder;
 import com.google.gwt.uibinder.client.UiField;
@@ -193,9 +195,16 @@
     }
 
     private void updateInfoPanel() {
-        VmNetworkInterface vmNetworkInterface = (VmNetworkInterface) 
getModel().getSelectedItem();
+        final VmNetworkInterface vmNetworkInterface = (VmNetworkInterface) 
getModel().getSelectedItem();
         if (vmNetworkInterface != null && 
!getTable().getSelectionModel().isSelected(vmNetworkInterface)) {
-            getTable().getSelectionModel().setSelected(vmNetworkInterface, 
true);
+            // first let list of items get updated, only then select item
+            Scheduler.get().scheduleDeferred(new ScheduledCommand() {
+
+                @Override
+                public void execute() {
+                    
getTable().getSelectionModel().setSelected(vmNetworkInterface, true);
+                }
+            });
         }
         vmInterfaceInfoPanel.updatePanel(vmNetworkInterface);
     }


-- 
To view, visit http://gerrit.ovirt.org/19736
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9ab512bc315a5f01e9ddb3fe7321b596b83e7cf3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lver...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to