Vojtech Szocs has posted comments on this change. Change subject: webadmin: fix tabs shown/hidden when tags selected/unselected ......................................................................
Patch Set 3: Code-Review+1 (2 comments) Overall the patch looks good, I have two comments (inline), please have a look, thanks! .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java Line 427 Line 428 Line 429 Line 430 Line 431 Greg, what about Volume main tab? (if I read this correctly, original code marks Volume main tab as visible regardless of selection in Tags tree) Line 840: Line 841: profileList = new VnicProfileListModel(); Line 842: listModelCollection.add(profileList); Line 843: Line 844: setItems(listModelCollection); Hm, maybe you could just use getItems in setAllListModelsUnavailable method instead of introducing listModelCollection? Line 845: Line 846: roleListModel = new RoleListModel(); Line 847: systemPermissionListModel = new SystemPermissionListModel(); Line 848: clusterPolicyListModel = new ClusterPolicyListModel(); -- To view, visit http://gerrit.ovirt.org/19379 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6cace6daecef58ee2726a22e880d5c31e03e275f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
