Doron Fediuck has posted comments on this change.
Change subject: engine: scheduling: add cluster overbooking
......................................................................
Patch Set 3:
(6 comments)
....................................................
Commit Message
Line 3: AuthorDate: 2013-09-16 14:22:02 +0200
Line 4: Commit: Gilad Chaplik <gchap...@redhat.com>
Line 5: CommitDate: 2013-09-30 17:41:59 +0200
Line 6:
Line 7: engine: scheduling: add cluster overbooking
scheduling: allow placement overbooking in cluster level.
Line 8:
Line 9: Added an option to the user to enable parallel VM scheduling for
cluster.
Line 10: by default this feature is hidden from the user (unless
Line 11: setting config.OptimizeSchedulerAllowOverBookingSupported to true).
Line 9: Added an option to the user to enable parallel VM scheduling for
cluster.
Line 10: by default this feature is hidden from the user (unless
Line 11: setting config.OptimizeSchedulerAllowOverBookingSupported to true).
Line 12:
Line 13: Change-Id: If52abf9974ab71b1f8d52ca268dac8dc39b89dc8
BZ?
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
Line 173: VdsFreeMemoryChecker memoryChecker) {
Line 174: clusterLockMap.putIfAbsent(cluster.getId(), new Semaphore(1));
Line 175: try {
Line 176: if (!cluster.isSchedulerAllowOverbooking()
Line 177: || !Config.<Boolean>
GetValue(ConfigValues.OptimizeSchedulerAllowOverBookingSupported)) {
Why || ?
Line 178: clusterLockMap.get(cluster.getId()).acquire();
Line 179: }
Line 180: List<VDS> vdsList = getVdsDAO()
Line 181: .getAllForVdsGroupWithStatus(cluster.getId(),
VDSStatus.Up);
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
Line 3295: @DefaultStringValue("Allow Overbooking")
Line 3296: String allowOverbookingLabel();
Line 3297:
Line 3298: @DefaultStringValue("Allows running cluster's scheulding
requests in parallel, which may cause in " +
Line 3299: "overbooking of cluster's resources")
Please add:
Note that using this option may cause running VMs or migrating VMs to fail due
to lack of resources, or in some scenarios overload the host with more VMs than
designed for. Use this option only if you are familiar with this behavior.
Line 3300: String allowSchedulingOverbookingInfo();
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java
Line 521:
schedulerOptimizationInfoIcon.setText(SafeHtmlUtils.fromTrustedString(
Line 522: templates.italicFixedWidth("350px",//$NON-NLS-1$
Line 523:
object.getSchedulerOptimizationInfoMessage()).asString()
Line 524: .replaceAll("(\r\n|\n)", "<br />")));
//$NON-NLS-1$ //$NON-NLS-2$
Line 525:
allowOverbookingInfoIcon.setVisible(allowOverbookingEditor.isVisible());
Is this hidden by default?
Line 526: }
Line 527:
Line 528: private void optimizationForServerFormatter(ClusterModel object) {
Line 529: if (object.getOptimizationForServer() != null
....................................................
File packaging/etc/engine-config/engine-config.properties
Line 73: MaxSchedulerWeight.description="Max weight score for a single
scheduler weight module"
Line 74: MaxSchedulerWeight.type=Integer
Line 75: OptimizeSchedulerForSpeedPendingRequests.description="Skip Host
weights if there are more than X requests pending for scheduling"
Line 76: OptimizeSchedulerForSpeedPendingRequests.type=Integer
Line 77: OptimizeSchedulerAllowOverBookingSupported.description="Disable
Scheduling synchronization, which could result in overbooking"
should be Scheduling resource synchronization.
Line 78: OptimizeSchedulerAllowOverBookingSupported.type=Boolean
Line 79: MaxStorageVdsDelayCheckSec.description="Max delay for check of domain
in seconds"
Line 80: MaxStorageVdsDelayCheckSec.type=Integer
Line 81: MaxStorageVdsTimeoutCheckSec.description="Max timeout for last check
of domain in seconds"
--
To view, visit http://gerrit.ovirt.org/19272
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If52abf9974ab71b1f8d52ca268dac8dc39b89dc8
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
