Doron Fediuck has posted comments on this change.
Change subject: engine: scheduling optimization field
......................................................................
Patch Set 3:
(2 comments)
See inline.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
Line 215: && (!cluster.isSchedulerOptimizeForSpeed()
Line 216: ||
clusterLockMap.get(cluster.getId()).getQueueLength() <=
Line 217: Config.<Integer>
GetValue(ConfigValues.OptimizeSchedulerForSpeedPendingRequests))) {
Line 218: bestHost = runFunctions(policy.getFunctions(),
vdsList, vm, parameters);
Line 219: }
else {
// Please log the fact that we're skipping the weights and why (including
pending requests number.
}
Line 220: if (bestHost != null) {
Line 221: getVdsDynamicDao().updatePartialVdsDynamicCalc(
Line 222: bestHost,
Line 223: 1,
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java
Line 76:
Line 77: private Map<String, String> clusterPolicyProperties;
Line 78: private boolean detectEmulatedMachine;
Line 79:
Line 80: private boolean schedulerOptimizeForSpeed;
Can you please initialize to false it in the c'tor?
Line 81:
Line 82: public VDSGroup() {
Line 83: migrateOnError = MigrateOnErrorOptions.YES;
Line 84: name = "";
--
To view, visit http://gerrit.ovirt.org/19270
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0784f89648093e650be73fcc3d850a4854d53c1a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
