Mike Kolesnik has posted comments on this change.

Change subject: core: cleanup VmNetworkInterfaceDAO and its test
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File 
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmNetworkInterfaceDAODbFacadeImpl.java
Line 120:     private static class VmNetworkInterfaceFullRowMapper implements 
ParameterizedRowMapper<VmNetworkInterface> {
Why not inherit from the regular mapper?

--
To view, visit http://gerrit.ovirt.org/3580
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica23483114dba6104dc4a60c7027100d03aeae07
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to