Shubhendu Tripathi has posted comments on this change.

Change subject: webadmin : gluster volume rebalance status on a volume whose 
all the hosts are down
......................................................................


Patch Set 1:

(1 comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeRebalanceStatusQuery.java
Line 47:             
getQueryReturnValue().setReturnValue(fetchTaskStatusDetails());
Line 48:         }
Line 49:     }
Line 50: 
Line 51:     private Object fetchTaskStatusDetails() {
Shouldnt we return VDSReturnValue itself here?
If some exception, succedded flag is set to false, else getReturnValue would 
have the status entity populated.
Line 52:         GlusterVolumeTaskStatusEntity entity = null;
Line 53:         VDSReturnValue returnValue = new VDSReturnValue();
Line 54:         try {
Line 55:             returnValue =


-- 
To view, visit http://gerrit.ovirt.org/19598
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie13748716f23a797fc0e3ec16acbb4150c43b7e8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to