Allon Mureinik has posted comments on this change. Change subject: engine: Display correct and user friendly size of iso files ......................................................................
Patch Set 3: Code-Review+1 (1 comment) Minor comment in the commit msg, please fix when you rebase. .................................................... Commit Message Line 8: Line 9: Previously all iso files appear under Storage -> Images with bogus size Line 10: of '< 1 GB' although some of them are larger than that. It happened Line 11: because the 'getIsoList' API between Engine and VDSM returned only file Line 12: names, so Engine had no choice and set their size to 0. s/and/but to/ Line 13: Line 14: Now this API returns all information VDSM keeps about these files Line 15: including their size so Engine can display the correct value. Line 16: -- To view, visit http://gerrit.ovirt.org/19549 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77bd99beb8138524b25f0afdcce0815ad8664f0f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches