Arik Hadas has uploaded a new change for review.
Change subject: core: fix unchecked cast
......................................................................
core: fix unchecked cast
Coverity scan detected unchecked cast from VdcActionParametersBase to
ImagesActionsParametersBase in CreateAllSnapshotsFromVmCommand class.
This patch solved it by verifing with 'instanceof' check that the cast
is safe.
Change-Id: I7da9f46ae0742efb376ce558be48b9357e906e85
Signed-off-by: Arik Hadas <aha...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/46/19646/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
index 45432ec..d9559ba 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
@@ -285,8 +285,11 @@
Collections.sort(sortedList, new Comparator<VdcActionParametersBase>()
{
@Override
public int compare(VdcActionParametersBase o1,
VdcActionParametersBase o2) {
- return ((ImagesActionsParametersBase)
o1).getDestinationImageId()
- .compareTo(((ImagesActionsParametersBase)
o2).getDestinationImageId());
+ if (o1 instanceof ImagesActionsParametersBase && o2 instanceof
ImagesActionsParametersBase) {
+ return ((ImagesActionsParametersBase)
o1).getDestinationImageId()
+ .compareTo(((ImagesActionsParametersBase)
o2).getDestinationImageId());
+ }
+ return 0;
}
});
--
To view, visit http://gerrit.ovirt.org/19646
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7da9f46ae0742efb376ce558be48b9357e906e85
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
