Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: Update sysconfig/nfs contents ......................................................................
Patch Set 4: (1 comment) .................................................... File packaging/conf/nfs.sysconfig.in Line 3: # You might want to also change iptables/firewalld. Line 4: RPCNFSDCOUNT=8 Line 5: LOCKD_TCPPORT=32803 Line 6: LOCKD_UDPPORT=32769 Line 7: RPCMOUNTDOPTS="-p 892" You are correct, the current change will overwrite existing settings. The code without this change overwrites the entire file. I think that it's better to only overwrite options we change. I might be wrong :-) I can think of all sorts of complex checks trying to identify exactly what the user changed and/or warn/ask/etc. about that, not sure it's needed. In any case, this change does fix a real problem (compatibility with recent fedora). We can always improve in later changes if needed. Line 8: RPCRQUOTADOPTS="-p 875" -- To view, visit http://gerrit.ovirt.org/19472 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc144c85a14e967c1994d35d36c3b3e16aa5ff77 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
