Roy Golan has posted comments on this change.

Change subject: tools: Add script to dump heap
......................................................................


Patch Set 8:

(1 comment)

....................................................
File packaging/bin/engine-heap-dump.sh
Line 30:        local heap="${prefix}heap.${pid}.txt"
Line 31: 
Line 32:        "${JMAP}" -histo -F ${PID} > "${histo}" \
Line 33:                || warn "Cannot dump histogram"
Line 34:        "${JMAP}" -heap ${PID} > "${heap}" \
I get an exception with jmap -heap because of java using the G1 garbage 
collector.

Oracle said they addressed that according to [1] but no luck here. 

can you verify the -heap has a correct input with no exceptions?

[1] http://www.oracle.com/technetwork/java/javase/jdk7-relnotes-418459.html
Line 35:                || warn "Cannot dump heap"
Line 36:        "${JMAP}" -F -dump:format=b,file="${dump}" ${PID} \
Line 37:                || warn "Cannot dump memory"
Line 38: 


-- 
To view, visit http://gerrit.ovirt.org/17470
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic337441123a7129d71c0a90aa4b12c8ec49c03c7
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Liran Zelkha <liran.zel...@gmail.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to