Kanagaraj M has posted comments on this change.

Change subject: webadmin : Change volume status to yellow when bricks down
......................................................................


Patch Set 3:

(1 comment)

....................................................
File 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeStatusCell.java
Line 60:             }
Line 61:         } else {
Line 62:             statusImage = resources.volumeUpWarning();
Line 63:             tooltip = constants.volumeBricksDown();
Line 64:         }
In case the volume is down, the status should be shown as down with a red-down 
icon. 

But here, up warning icon will be shown even if the volume is down
Line 65:         // Generate the HTML for the image:
Line 66:         SafeHtml statusImageHtml =
Line 67:                 
SafeHtmlUtils.fromTrustedString(AbstractImagePrototype.create(statusImage).getHTML());
Line 68:         sb.append(applicationTemplates.statusTemplate(statusImageHtml, 
tooltip));


-- 
To view, visit http://gerrit.ovirt.org/19611
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iddaf1676bf9bf2c3aa0d4381e5057e21d4c8512e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to