Sandro Bonazzola has posted comments on this change. Change subject: packaging: support modifying java module path ......................................................................
Patch Set 3: Juan: > Replacing a file is something that any system administrator can do and track, > no special knowledge required for that. On the other hand creating a new > module and updating the engine configuration does require some extra > knowledge. I think that allowing the administrator to replace a file should be avoided: you'll not know that the admin has done that unless you track all the modules versions in sos reports / log collector. However, as also Alon said, the administrator without additional knowledge may still replace the files. > Replacing the file means that it will be overwritten by the next z-stream. > That is bad, as the change will be lost. But shading the module means that it > won't be overwritten, even if we provide a new version that fixes the > original problem and probably many others, the shaded module will stay there > for ever. This is much worse. Is there a way for detecting if we're using a module with different version than the one we shipped? Can we issue a warning somehow? -- To view, visit http://gerrit.ovirt.org/19586 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibda53f67fa801cf4eb00b11483e9a6ab712d4d74 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
