Tomas Jelinek has posted comments on this change. Change subject: webadmin: Add/Remove VNICs in Add/Edit VM dialog ......................................................................
Patch Set 1: (2 comments) .................................................... File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfilesInstanceTypeEditor.java Line 121: item.edit(value); Line 122: item.setElementId(elementId); Line 123: Line 124: // small workaround due to UiCommonEditorVisitor changing null selected value Line 125: value.setSelectedItem(profile); I did not get this workaround - why is this needed? Line 126: Line 127: return item; Line 128: } Line 129: .................................................... File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java Line 179: public Panel logicalNetworksEditorPanel; Line 180: Line 181: @UiField Line 182: @Ignore Line 183: public ProfilesInstanceTypeEditor profilesInstanceTypeEditor; why does this have no elementId? Line 184: Line 185: @UiField Line 186: @Ignore Line 187: Label generalWarningMessage; -- To view, visit http://gerrit.ovirt.org/19531 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7654d137541aec64ce19aa309021b307253171e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
