Kanagaraj M has posted comments on this change. Change subject: gluster: Corrected the alert message for rebalance ......................................................................
Patch Set 1: (1 comment) .................................................... File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties Line 930: ACTION_TYPE_FAILED_GLUSTER_VOLUME_IS_UP=Cannot ${action} ${type}. Gluster volume ${volumeName} is up. Line 931: ACTION_TYPE_FAILED_GLUSTER_VOLUME_IS_DOWN=Cannot ${action} ${type}. Gluster Volume is down. Line 932: ACTION_TYPE_FAILED_CAN_NOT_REMOVE_ALL_BRICKS_FROM_VOLUME=Cannot ${action} ${type}. Cannot remove all the bricks from a Volume. Line 933: ACTION_TYPE_FAILED_GLUSTER_VOLUME_SHOULD_BE_STARTED=Cannot ${action} ${type}. Gluster Volume should be started. Line 934: ACTION_TYPE_FAILED_GLUSTER_VOLUME_BRICKS_ARE_NOT_DISTRIBUTED=Cannot ${action} ${type}. Gluster Volume has a single brick. I feel there should 2 error messages, one for the volume which is not distributed another one the volume which is distributed but has a single brick Otherwise the error message would misleading, if the StartRebalance was executed for a Replicate volume Line 935: ACTION_TYPE_FAILED_NOT_A_GLUSTER_VOLUME_BRICK=Cannot ${action} ${type}. Replacing brick is not a Gluster volume brick. Line 936: ACTION_TYPE_FAILED_NO_GLUSTER_HOST_TO_PEER_PROBE=Cannot ${action} ${type}. There is no available server in the cluster to probe the new server. Line 937: ACTION_TYPE_FAILED_CAN_NOT_REDUCE_REPLICA_COUNT_MORE_THAN_ONE=Cannot ${action} ${type}. Replica count cannot be reduced by more than one. Line 938: ACTION_TYPE_FAILED_CAN_NOT_INCREASE_REPLICA_COUNT=Cannot ${action} ${type}. Replica count cannot be increased when removing bricks. -- To view, visit http://gerrit.ovirt.org/19570 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I449d86daca772a1557e94d9f01cf5a170c749782 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches