Kanagaraj M has posted comments on this change.
Change subject: engine:BLL Command modified to return status after rebalance
stop
......................................................................
Patch Set 1:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StopRebalanceGlusterVolumeCommand.java
Line 69: // Run the VDSM verb to get the status
Line 70: VDSReturnValue vdsRettunValueStatus =
Line 71:
runVdsCommand(VDSCommandType.GetGlusterVolumeRebalanceStatus,
Line 72: new
GlusterVolumeVDSParameters(upServer.getId(), getGlusterVolumeName()));
Line 73:
What if the above command fails?
Line 74: // Set the volume re-balance start time
Line 75: GlusterVolumeTaskStatusEntity entity =
Line 76: (GlusterVolumeTaskStatusEntity)
vdsRettunValueStatus.getReturnValue();
Line 77: List<Step> stepsList =
Line 77: List<Step> stepsList =
Line 78: getDbFacade().getStepDao()
Line 79:
.getStepsByExternalId(getGlusterVolumeDao().getById(getParameters().getVolumeId())
Line 80: .getAsyncTask()
Line 81: .getStepId());
taskId should be passed to getStepsByExternalId() instead of stepId.
Also getGlusterVolume().getAsyncTask() can be used here.
Line 82: if (stepsList != null && !stepsList.isEmpty()) {
Line 83: entity.setStartTime(stepsList.get(0).getStartTime());
Line 84: }
Line 85: getReturnValue().setActionReturnValue(entity);
--
To view, visit http://gerrit.ovirt.org/19585
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica92511e4898e2119eec312854f390a22152e212
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
