Juan Hernandez has uploaded a new change for review.
Change subject: core: Prevent NPE with cobertura
......................................................................
core: Prevent NPE with cobertura
The NetworkDaoDbFacadeImpl contains an abstract row mapper and then two
derived ones, and all of them, including the abstract one contain a
singleton. The singleton in the abstract one is never used, and it
causes a NPE if used. Some tools, like cobertura, generate code that
uses all the fields, and thus reveal this hidden NPE. This patch just
removes the unused field.
Change-Id: I811fe567010037fd12e4deeb517fb3396c724b53
Signed-off-by: Juan Hernandez <juan.hernan...@redhat.com>
---
M
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkDaoDbFacadeImpl.java
1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/71/19571/1
diff --git
a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkDaoDbFacadeImpl.java
b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkDaoDbFacadeImpl.java
index e87f01e..e6b41b0 100644
---
a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkDaoDbFacadeImpl.java
+++
b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkDaoDbFacadeImpl.java
@@ -142,8 +142,6 @@
}
abstract static class NetworkRowMapperBase<T extends Network> implements
RowMapper<T> {
- public final static NetworkRowMapper instance = new NetworkRowMapper();
-
@Override
public T mapRow(ResultSet rs, int rowNum) throws SQLException {
T entity = createNetworkEntity();
--
To view, visit http://gerrit.ovirt.org/19571
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I811fe567010037fd12e4deeb517fb3396c724b53
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
