Moti Asayag has uploaded a new change for review.

Change subject: engine: Expand nics filter criteria
......................................................................

engine: Expand nics filter criteria

The engine query for retrieving the host nics should
consider nics which aren't bonds either by
VdsNetworkInterface.getBonded() being equal to null or
to Boolean.False.

Change-Id: I587e51efaf935fafbfbe814bb4a1f1dea1a5ab94
Bug-Url: https://bugzilla.redhat.com/1011486
Signed-off-by: Moti Asayag <masa...@redhat.com>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetVdsInterfacesByVdsIdQuery.java
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/48/19548/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetVdsInterfacesByVdsIdQuery.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetVdsInterfacesByVdsIdQuery.java
index b660c28..5102b67 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetVdsInterfacesByVdsIdQuery.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetVdsInterfacesByVdsIdQuery.java
@@ -50,8 +50,8 @@
             Map<String, Network> networks = Entities.entitiesByName(
                     
getDbFacade().getNetworkDao().getAllForCluster(vdsStatic.getVdsGroupId()));
             for (final VdsNetworkInterface i : list) {
-                if (i.getBonded() == null || (i.getBonded() != null && 
i.getBonded())
-                            && LinqUtils.filter(list, new 
Predicate<VdsNetworkInterface>() {
+                if (!Boolean.TRUE.equals(i.getBonded())
+                        || LinqUtils.filter(list, new 
Predicate<VdsNetworkInterface>() {
                                 @Override
                                 public boolean eval(VdsNetworkInterface bond) {
                                     return 
StringUtils.equals(bond.getBondName(), i.getName());


-- 
To view, visit http://gerrit.ovirt.org/19548
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I587e51efaf935fafbfbe814bb4a1f1dea1a5ab94
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to